Integrated: 8351484: Race condition in max stats in MonitorList::add

Aleksey Shipilev shade at openjdk.org
Wed Mar 12 07:24:03 UTC 2025


On Mon, 10 Mar 2025 11:30:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See bug for the description of the race. New gtest test case reliably catches fire on my 5950X desktop without this fix.
> 
> I needed to add the proper constructor for `MonitorList` to make it testable. In our regular code, it is statically allocated, so its fields are implicitly initialized.
> 
> I also made counter updates `_relaxed` for completeness.
> 
> Additional testing:
>  - [x] Linux x86_64 server fastdebug, new test now passes
>  - [x] Linux x86_64 server fastdebug, `all`
>  - [x] GHA

This pull request has now been integrated.

Changeset: 1d147ccb
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1d147ccb4cfcb1da23664ac941e56ac542a7ac61
Stats:     48 lines in 3 files changed: 44 ins; 0 del; 4 mod

8351484: Race condition in max stats in MonitorList::add

Reviewed-by: pchilanomate, zgu

-------------

PR: https://git.openjdk.org/jdk/pull/23961


More information about the hotspot-runtime-dev mailing list