RFR: 8351651: Cleanup LockStack::is_owning_thread [v5]

[Stefan Karlsson]

On Tue, 11 Mar 2025 16:17:43 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is a minor mostly trivial change I found while reading through code looking for something else.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restore lightweight case and removed NOT_PRODUCT.

OK, if that is what you want.

As I wrote, I've backed off on my earlier ask to keep the function a product function (including my request for reducing the line noise created by making this a debug-only function).

However, I still think it is important that we don't rush in code that is confusing and/or risks causing the next developer to be confused when the compiler/linker starts to complain. So, if that's a too large ask then I also think that it is good to close not make this change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23981#issuecomment-2718232015