RFR: 8319055: JCMD should not buffer the whole output of commands [v6]

[Alex Menkov]

On Mon, 10 Feb 2025 18:25:58 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>>> I didn't really understand what makes this streaming. The old protocol first sent out the result, and then the data, has this changed?
>> 
>> The protocol works as before.
>> All command handlers are updated to set the result code earlier (after argument parsing, but before command execution).
>> After the result code is set, it's sent to the tool and the rest of output (data) are send directly to the tool without buffering.
>
>> > I didn't really understand what makes this streaming. The old protocol first sent out the result, and then the data, has this changed?
>> 
>> The protocol works as before. All command handlers are updated to set the result code earlier (after argument parsing, but before command execution). After the result code is set, it's sent to the tool and the rest of output (data) are send directly to the tool without buffering.
> 
> Aha, I understand. Before, result code meant "Parsing OK, Command Execution OK", now it means "Parsing OK, starting Command Execution". That's fine by me.
> 
> Edit: I'll perform another review round soon!

@jdksjolen , @tstuefe  can you re-review with the last commit please

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23405#issuecomment-2718898375