RFR: 8351689: -Xshare:dump with default classlist fails on static JDK [v2]
Jiangli Zhou
jiangli at openjdk.org
Thu Mar 13 23:36:41 UTC 2025
On Thu, 13 Mar 2025 21:19:56 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address iklam's comment:
>> - Use get_default_classlist helper function.
>
> src/hotspot/share/cds/metaspaceShared.cpp line 869:
>
>> 867:
>> 868: jio_snprintf(default_classlist, JVM_MAXPATHLEN, "%s%slib%sclasslist",
>> 869: Arguments::get_java_home(), filesep, filesep);
>
> I think it's better to move this logic into `MetaspaceShared::get_default_classlist()` to avoid duplication.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24000#discussion_r1994430230
More information about the hotspot-runtime-dev
mailing list