RFR: 8352084: Add more test code in TestSetupAOT.java [v2]
Ioi Lam
iklam at openjdk.org
Sat Mar 15 02:08:34 UTC 2025
On Fri, 14 Mar 2025 23:43:53 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments from @erikj79 and @lmesnik
>
> make/test/BuildTestSetupAOT.gmk line 62:
>
>> 60: JavacBenchApp$$FileManager.class \
>> 61: JavacBenchApp$$SourceFile.class \
>> 62: TestSetupAOT.class, \
>
> Listing all class files like this is cumbersome. Perhaps we should build this into a jar file instead now that there are more classes? It should be as easy as adding `JAR := <name of jar>` to the SetupJavaCompilation call above and then copy that file. Or would that interfere with the classpath requirements when using the tool?
I changed the output to a JAR file so there's no need to enumerate all classes. When running the tool, I need to extract the class files to `$$($1_AOT_JDK_OUTPUT_DIR)` due to the reasons described in RunTests.gmk.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24067#discussion_r1996506325
More information about the hotspot-runtime-dev
mailing list