RFR: 8351689: -Xshare:dump with default classlist fails on static JDK [v2]

[David Holmes]

On Thu, 13 Mar 2025 23:36:40 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Please review the change to use `Arguments::get_java_home` to resolve the default classlist path. This avoids the complication of walking up the directory from libjvm and the subtle handling for '/lib' dir, which is what `MetaspaceShared::get_default_classlist` needs to do. This fixes the failure on static JDK for running `-Xshare:dump` with the default classlist. Please see more details in https://bugs.openjdk.org/browse/JDK-8351689.
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address iklam's comment:
>   - Use get_default_classlist helper function.

This seems much simpler regardless of static: walk down from the top, rather up from the bottom.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24000#pullrequestreview-2689345101