RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v2]
Afshin Zafari
azafari at openjdk.org
Mon Mar 17 09:58:54 UTC 2025
On Fri, 14 Mar 2025 16:04:04 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> One StackIndex is used for all reserve/commit/uncommit/release operations.
>> We need another one just used for committing and uncommitting the start-node of the reserved region.
>> So names like ReserveXXX and CommitXXX would not fit.
>> I do not insist on the chosen names and am open to proper alternatives.
>
> In your gtest you have a test called "SeparateStacksForCommitAndReserve", which seems to say to me, that commit and reserve would be good names?
The full name should be something like:
commit_stack_at_start_of_region
or
stack_for_commit_at_region_base
Although it is also used for uncommit but we don't show uncommit stack traces in NMT report.
What do you think? Any other better naming?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r1998362656
More information about the hotspot-runtime-dev
mailing list