RFR: 8351382: New test containers/docker/TestMemoryWithSubgroups.java is failing [v3]
Sergey Chernyshev
schernyshev at openjdk.org
Mon Mar 17 16:00:49 UTC 2025
On Mon, 17 Mar 2025 13:51:29 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix Podman emulating Docker CLI.
>
> test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java line 58:
>
>> 56: return (getEngineInfo("{{.Host.Security.Rootless}}").contains("true") ||
>> 57: getEngineInfo("{{.SecurityOptions}}").contains("name=rootless"));
>> 58: }
>
> Please add a comment why need to check both (i.e. `docker => .SecurityOptions; podman => .Host.Security.Rootless`. Now it's no longer clear why we query two different values.
done, added.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23948#discussion_r1999088053
More information about the hotspot-runtime-dev
mailing list