RFR: 8352178: Add precondition in Handshake::execute to prevent deadlock [v2]

[Aleksey Shipilev]

On Tue, 18 Mar 2025 08:48:21 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple patch of adding `SuspendibleThreadSet` related precondition to `Handshake::execute` in order to prevent deadlock.
>> All existing callsites satisfy this precondition already.
>> 
>> Test: tier1-5
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/hotspot/share/runtime/handshake.cpp
>   
>   Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>

Looks reasonable. Have you caught the deadlock like this anywhere, e.g. in development for some feature?

GHA is misbehaving a bit, not the fault of this patch, I think. Still, maybe wait a little and trigger more GHA runs to see if the patch is green?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24088#pullrequestreview-2693596863