RFR: 8352084: Add more test code in TestSetupAOT.java [v4]

[Magnus Ihse Bursie]

On Mon, 17 Mar 2025 16:35:12 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> I modified TestSetupAOT.java to exercise more functionalities in the JDK so that we can have a more substantial AOT cache when running tests with `AOT_JDK=true`. E.g:
>> 
>> 
>> make test JTREG=AOT_JDK=true \
>>     TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java
>> 
>> 
>> Before: the generated AOT cache was about 20 MB, with 2245 classes and 125 resolved indies
>> After:  the generated AOT cache is about 34 MB, with 4703 classes and 912 resolved indies
>> 
>> I verified with Mach5 tiers 4, 5, 6, 10 with all tests tasks that have the label `.*aot.jdkcache.*`
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @erikj79 comments

make/RunTests.gmk line 757:

> 755: 	$$(call LogWarn, AOT: Create cache configuration) \
> 756: 	$$(call ExecuteWithLog, $$($1_AOT_JDK_OUTPUT_DIR), ( \
> 757:             cd $$($1_AOT_JDK_OUTPUT_DIR); \

@iklam I missed commenting on both this and the prior PR that introduced this function, but if you go back and modify this function again, please use `&&` instead of `;` to separate shell commands. That will chain them so that if the first one fails, the rest will not be executed. (We are setting the `-e` flag so the current code should have the same behavior, but writing `&&` makes it explicit for the reader, and is the style we have been adopting elsewhere in the build system.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24067#discussion_r2000860852