RFR: 8352256: ObjectSynchronizer::quick_notify misses JFR event notification path
Coleen Phillimore
coleenp at openjdk.org
Tue Mar 18 12:05:06 UTC 2025
On Tue, 18 Mar 2025 11:42:39 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Noticed this while removing OM counters. When doing [JDK-8351187](https://bugs.openjdk.org/browse/JDK-8351187), I apparently forgot to cover a path from `ObjectSynchronizer::quick_notify`, probably due to concurrent renames. I think we can cover this gap while still simplifying the code: let `ObjectMonitor` handle all events, DTrace, JFR, OM stats.
>
> Additional testing:
> - [x] Linux x86_64 server fastdebug, `jdk_jfr`
This looks good. At one point, because of this lack of encapsulation, I wanted us to get rid of quick_notify because I didn't think it was quicker. This improves the encapsulation too and we can figure out if it's useful later.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24097#pullrequestreview-2694257790
More information about the hotspot-runtime-dev
mailing list