Integrated: 8347734: Turning off PerfData logging doesn't work

Casper Norrbin cnorrbin at openjdk.org
Thu Mar 20 12:28:32 UTC 2025


On Thu, 13 Mar 2025 15:07:07 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

> Hi everyone,
> 
> When PerfData is disabled, the corresponding perfdata variables remain uninitialized. However, under certain conditions, logging may attempt to access these variables, leading to a crash. The existing code turns off the relevant tags using `LogConfiguration::configure_stdout`, but this doesn't modify other outputs. For example, the test `runtime/logging/RedefineClasses.java` crashes with `-XX:-UsePerfData` because it uses an output that isn't stdout.
> 
> To fix this, I've added a new method `LogConfiguration::disable_tags`. Unlike `configure_stdout`, this function iterates over all outputs and disables the specified tags on each. This way, we correctly disable tags across all outputs and longer try and access the uninitialized perfdata variables.

This pull request has now been integrated.

Changeset: 73177d9c
Author:    Casper Norrbin <cnorrbin at openjdk.org>
Committer: David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/73177d9c53ba02e9c358991774023619afe8379a
Stats:     64 lines in 4 files changed: 57 ins; 3 del; 4 mod

8347734: Turning off PerfData logging doesn't work

Reviewed-by: dholmes, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/24036


More information about the hotspot-runtime-dev mailing list