RFR: 8351655: Optimize ObjectMonitor::unlink_after_acquire() [v2]

Fredrik Bredberg fbredberg at openjdk.org
Thu Mar 20 14:56:29 UTC 2025


On Thu, 20 Mar 2025 05:54:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/runtime/objectMonitor.cpp line 1265:
>> 
>>> 1263: // entry_list head after the entry_list was last converted into a
>>> 1264: // doubly linked list.
>>> 1265: void ObjectMonitor::entry_list_build_dll(JavaThread* current) {
>> 
>> We only call this from unlink_after_acquire() and exit() when we know the list is not empty, so why not assert that here and remove case 1?
>
> I agree.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24078#discussion_r2005826439


More information about the hotspot-runtime-dev mailing list