RFR: 8351655: Optimize ObjectMonitor::unlink_after_acquire() [v2]

Fredrik Bredberg fbredberg at openjdk.org
Thu Mar 20 15:00:16 UTC 2025


On Thu, 20 Mar 2025 05:42:41 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after review
>
> src/hotspot/share/runtime/objectMonitor.cpp line 1264:
> 
>> 1262: // Number four is because new threads has pushed themself to the
>> 1263: // entry_list head after the entry_list was last converted into a
>> 1264: // doubly linked list.
> 
> I suggest deleting this as we already know it from the description of how things work.

I like to add comments locally that helps the reader to understand things without having to seek out a "how things work" section. If you feel strongly that it should be removed, I'll do it, but if not I'd rather keep it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24078#discussion_r2005840894


More information about the hotspot-runtime-dev mailing list