RFR: 8351655: Optimize ObjectMonitor::unlink_after_acquire() [v2]

[Fredrik Bredberg]

On Fri, 21 Mar 2025 04:54:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after review
>
> src/hotspot/share/runtime/objectMonitor.cpp line 1254:
> 
>> 1252: 
>> 1253: // Convert entry_list into a doubly linked list by assigning the prev
>> 1254: // pointers and the entry_list_tail pointer. Within the entry_list the
> 
> Suggestion:
> 
> // pointers and the entry_list_tail pointer (if needed). Within the entry_list the
> 
> If the bottom end of the list is already DL then the tail will already be set.

Fixed

> src/hotspot/share/runtime/objectMonitor.cpp line 1272:
> 
>> 1270:   // This function should only be called when we know that the
>> 1271:   // entry_list is not empty.
>> 1272:   assert(w != nullptr, "invariant");
> 
> Suggestion - no comments just:
> 
> assert(w != nullptr, "should only be called when entry list is not empty");

Fixed

> src/hotspot/share/runtime/objectMonitor.cpp line 1321:
> 
>> 1319:   entry_list_build_dll(current);
>> 1320:   w = _entry_list_tail;
>> 1321:   assert(w != nullptr, "should be");
> 
> Suggestion:
> 
>   assert(w != nullptr, "invariant");

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24078#discussion_r2007162344
PR Review Comment: https://git.openjdk.org/jdk/pull/24078#discussion_r2007159670
PR Review Comment: https://git.openjdk.org/jdk/pull/24078#discussion_r2007161789