RFR: 8351655: Optimize ObjectMonitor::unlink_after_acquire() [v3]

Fredrik Bredberg fbredberg at openjdk.org
Fri Mar 21 09:28:08 UTC 2025


On Fri, 21 Mar 2025 05:25:26 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I like to add comments locally that helps the reader to understand things without having to seek out a "how things work" section. If you feel strongly that it should be removed, I'll do it, but if not I'd rather keep it.
>
> Local comments where the code is not obvious sure. But we have over 100 lines of commentary describing the operations of this list including that it can be singly or doubly linked, so I really don't think we need this level of detail again at this point in the code.

Ok, no problem, I removed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24078#discussion_r2007170264


More information about the hotspot-runtime-dev mailing list