RFR: 8325132: CDS: Make sure the ArchiveRelocationMode is always printed in the log

Aleksey Shipilev shade at openjdk.org
Tue Mar 25 19:38:27 UTC 2025


On Tue, 4 Mar 2025 00:44:55 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Always include the ArchiveRelocationMode in the CDS info log. Before this fix, ArchiveRelocationMode is not in the log if it is set to 0.
> The ArchiveRelocationMode default value was set to 1 about 2 years ago. Some tests need to be updated accordingly.
> 
> Testing:
> 
> - ran the modified tests manually on linux-x64
> - tier1

Looks okay to me, with a nit:

src/hotspot/share/cds/metaspaceShared.cpp line 1169:

> 1167:     dynamic_mapinfo = open_dynamic_archive();
> 1168: 
> 1169:     log_info(cds)("ArchiveRelocationMode = %d", ArchiveRelocationMode);

Looks like the style in adjacent output is `Archive relocation mode: %d`. How does the `-Xlog:cds` look with this change?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23878#pullrequestreview-2714900275
PR Review Comment: https://git.openjdk.org/jdk/pull/23878#discussion_r2012772074


More information about the hotspot-runtime-dev mailing list