RFR: 8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106 [v2]

Richard Reingruber rrich at openjdk.org
Wed Mar 26 07:23:07 UTC 2025


On Tue, 25 Mar 2025 20:19:30 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

>> Add missing header to resolve the compilation failure.
>> 
>> Testing:
>>  - built openjdk in PPC qemu vm.
>
> Vladimir Petko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix: use generic os_linux.hpp

Thanks for taking care of the issue!

src/hotspot/os_cpu/linux_ppc/javaThread_linux_ppc.cpp line 27:

> 25: 
> 26: #include "memory/metaspace.hpp"
> 27: #include "os_linux.hpp"

I think you should include `os_linux.inline.hpp` (according to the [style-guide](https://github.com/openjdk/jdk/blob/2e4d7d1846d846fd98201b9b3abeb7b91239a40d/doc/hotspot-style.md?plain=1#L163)).

-------------

Changes requested by rrich (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24216#pullrequestreview-2716115534
PR Review Comment: https://git.openjdk.org/jdk/pull/24216#discussion_r2013522699


More information about the hotspot-runtime-dev mailing list