RFR: 8352435: Refactor CDS test library for execution and module packaging [v2]

[Ioi Lam]

On Wed, 26 Mar 2025 17:32:17 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added comments
>
> test/lib/jdk/test/lib/cds/CDSJarUtils.java line 224:
> 
>> 222:             }
>> 223:         }
>> 224:         System.out.println();
> 
> Should this be printed only if DEBUG is enabled?

I think it's better to always print the files being compiled, as jtreg also does the same thing for files that it compiles. That way it's easy to diagnose problems in the test source code.

> test/lib/jdk/test/lib/cds/CDSModulePackager.java line 28:
> 
>> 26: 
>> 27: import java.io.File;
>> 28: import java.nio.file.Files;
> 
> Unused import.

Fixed

> test/lib/jdk/test/lib/cds/CDSModulePackager.java line 33:
> 
>> 31: import jdk.test.lib.StringArrayUtils;
>> 32: import jdk.test.lib.compiler.CompilerUtils;
>> 33: import jdk.test.lib.util.FileUtils;
> 
> Unused import.

Fixed

> test/lib/jdk/test/lib/cds/SimpleCDSAppTester.java line 29:
> 
>> 27: import jdk.test.lib.Asserts;
>> 28: import jdk.test.lib.cds.CDSTestUtils;
>> 29: import jdk.test.lib.process.ProcessTools;
> 
> Unused import.

Fixed

> test/lib/jdk/test/lib/cds/SimpleCDSAppTester.java line 33:
> 
>> 31: import jdk.test.lib.StringArrayUtils;
>> 32: import jdk.test.whitebox.WhiteBox;
>> 33: import jtreg.SkippedException;
> 
> Unused import.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24122#discussion_r2014892588
PR Review Comment: https://git.openjdk.org/jdk/pull/24122#discussion_r2014893047
PR Review Comment: https://git.openjdk.org/jdk/pull/24122#discussion_r2014892969
PR Review Comment: https://git.openjdk.org/jdk/pull/24122#discussion_r2014892931
PR Review Comment: https://git.openjdk.org/jdk/pull/24122#discussion_r2014892879