RFR: 8352435: Refactor CDS test library for execution and module packaging [v2]

[Ioi Lam]

On Tue, 25 Mar 2025 17:55:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added comments
>
> test/hotspot/jtreg/runtime/cds/appcds/aotClassLinking/AOTClassLinkingVMOptions.java line 111:
> 
>> 109:         String MAIN_CLASS = "com.foos.Test";
>> 110: 
>> 111:         String appClasses[] = {MAIN_CLASS};
> 
> Suggestion:
> 
>         String[] appClasses = {MAIN_CLASS};

Fixed.

> test/hotspot/jtreg/runtime/cds/appcds/jigsaw/modulepath/ExportModule.java line 99:
> 
>> 97:         OutputAnalyzer output = TestCommon.createArchive(
>> 98:                                         appJar1.toString(), appClasses,
>> 99:                                         "--module-path", moduleDir2.toString(),
> 
> Is this correct to use `appJar1` but `moduleDir2`?

This is actually correct but it's not clear from the names of the variables. I've updated the names and added comments for clarification (but otherwise the logic is unchanged).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24122#discussion_r2014889730
PR Review Comment: https://git.openjdk.org/jdk/pull/24122#discussion_r2014889677