RFR: 8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106 [v2]
Richard Reingruber
rrich at openjdk.org
Wed Mar 26 20:24:10 UTC 2025
On Wed, 26 Mar 2025 17:31:46 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> src/hotspot/os_cpu/linux_ppc/javaThread_linux_ppc.cpp line 27:
>>
>>> 25:
>>> 26: #include "memory/metaspace.hpp"
>>> 27: #include "os_linux.hpp"
>>
>> I think you should include `os_linux.inline.hpp` (according to the [style-guide](https://github.com/openjdk/jdk/blob/2e4d7d1846d846fd98201b9b3abeb7b91239a40d/doc/hotspot-style.md?plain=1#L163)).
>
> Not really? I think that rule only says "do not include `os_linux.hpp` if `os_linux.inline.hpp` is already included". We do not include `os_linux.inline.hpp`, so we should include just the `os_linux.hpp`.
You're right. I misread this rule as a rule I expected to exist too (always prefer the *.inline.hpp over *.hpp).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24216#discussion_r2014944203
More information about the hotspot-runtime-dev
mailing list