RFR: 8352046: Test testEcoFriendly() in jdk tools launcher ExecutionEnvironment.java for AIX and Linux/musl is brittle [v3]

Christoph Langer clanger at openjdk.org
Thu Mar 27 13:53:15 UTC 2025


On Thu, 27 Mar 2025 13:28:13 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup
>
> test/jdk/tools/launcher/ExecutionEnvironment.java line 28:
> 
>> 26:  * @bug 4780570 4731671 6354700 6367077 6670965 4882974
>> 27:  * @summary Checks for LD_LIBRARY_PATH and execution  on *nixes
>> 28:  * @requires os.family != "windows" & !vm.musl & os.family != "aix"
> 
> Hello @JoKern65, I haven't yet fully grasped the change, but I think the:
> 
> @requires os.family != "windows"
> 
> part should still be retained to prevent this test from being launched on Windows.

Good catch. The test doesn't fail on Windows but it also doesn't make sense because it aims to test Unix specific things.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24055#discussion_r2016709613


More information about the hotspot-runtime-dev mailing list