RFR: 8352392: AIX: implement attach API v2 and streaming output [v3]

[Martin Doerr]

On Fri, 28 Mar 2025 09:01:26 GMT, Varada M <varadam at openjdk.org> wrote:

>> AIX changes for attach API to support arbitrary length arguments and the streaming output support. 
>> serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes
>> 
>> tier1, tier2 and tier3 testing is successful with fastdebug level
>> 
>> JBS Issue : [JDK-8352392](https://bugs.openjdk.org/browse/JDK-8352392)
>
> Varada M has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - updated copyright header
>  - removed StreamingOutputTest.java from problem list

I think this is good. @JoKern65: Do you also want to review it?

src/hotspot/os/aix/attachListener_aix.cpp line 119:

> 117:   void close() {
> 118:     if (opened()) {
> 119:       ::shutdown(_socket, 2);

If there is no macro like `SHUT_RDWR` available, maybe add it as a comment?

src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java line 125:

> 123:              } finally {
> 124:                  close(s);
> 125:              }

Indentation is off by 1 in this hunk.

src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java line 196:

> 194:          }
> 195:      }
> 196: 

Same here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24177#pullrequestreview-2728824060
PR Review Comment: https://git.openjdk.org/jdk/pull/24177#discussion_r2020765326
PR Review Comment: https://git.openjdk.org/jdk/pull/24177#discussion_r2020767818
PR Review Comment: https://git.openjdk.org/jdk/pull/24177#discussion_r2020768721