RFR: 8352092: -XX:AOTMode=record crashes with InstanceKlass in allocated state [v2]

[Ioi Lam]

On Mon, 31 Mar 2025 20:32:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Move CollectClassesForLinking inside while loop to see classes loaded as side effect of linking
>>  - @coleenp comments - use ClassLoaderDataGraph::loaded_classes_do_keepalive()
>
> src/hotspot/share/cds/metaspaceShared.cpp line 690:
> 
>> 688: 
>> 689: public:
>> 690:   CollectClassesForLinking() {}
> 
> Do you need this empty constructor?  _mirrors is initialized by default initializer to a small array, or should you give this a length?

I've removed the default constructor. I'll leave `_mirrors` as is as this code is not performance critical and the expansion overhead would be negligible .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24172#discussion_r2021741417