RFR: 8355711: Remove incorrect overflow check in RawBytecodeStream::raw_next [v3]

Dean Long dlong at openjdk.org
Thu May 1 21:12:46 UTC 2025


On Wed, 30 Apr 2025 09:43:25 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> This fixes a typical wrong overflow check. `_bci` and `_next_bci` are both `int`, so any overflow is undefined, therefore an optimizing C++ compiler is allowed to remove this check. When looking at the x64 assembly for this, I could not find the check, so I guess that it was actually removed as well.
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove

Look good, and my testing passed.  However, I think this deserves a 2nd review.

-------------

Marked as reviewed by dlong (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24920#pullrequestreview-2810736044


More information about the hotspot-runtime-dev mailing list