RFR: 8356102: TestJcmdOutput, JcmdWithNMTDisabled and DumpSharedDictionary hs/tier1 tests fail on static-jdk
Jiangli Zhou
jiangli at openjdk.org
Fri May 2 23:20:54 UTC 2025
Please review the change to set `-Dcompile.jdk=<jdk>` when launching child processes in TestJcmdOutput, JcmdWithNMTDisabled and DumpSharedDictionary hs/tier1 tests.
These three tests fail on static-jdk as `jdk.test.lib.JDKToolFinder.getJDKTool()` fails to locate the `jcmd` tool. `JDKToolFinder.getJDKTool()` locates the requested tool from the path specified in 'test.jdk' system property first, then using the path specified in 'compile.jdk' system property. Currently when running jtreg tests on static-jdk, jtreg '-compilejdk' is set to a regular JDK binary. Populating the 'compile.jdk' system property from jtreg when creating the child process would allow `JDKToolFinder.getJDKTool()` (executing in the child process) to locate the tool from 'compile.jdk' path.
Tested all three tests on static-jdk. All three tests pass with the fix.
-------------
Commit messages:
- Set -Dcompile.jdk=<> in launched test process.
Changes: https://git.openjdk.org/jdk/pull/25018/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25018&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8356102
Stats: 11 lines in 3 files changed: 6 ins; 2 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/25018.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25018/head:pull/25018
PR: https://git.openjdk.org/jdk/pull/25018
More information about the hotspot-runtime-dev
mailing list