RFR: 8356407: Part of class verification is skipped in AOT training run [v2]

[Matias Saavedra Silva]

On Wed, 7 May 2025 21:52:35 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please see [JDK-8356407](https://bugs.openjdk.org/browse/JDK-8356407) for a detailed description of the problem.
>> 
>> This fix strictly tightens the handling of class verification during CDS dump -- now the `VerificationType::is_reference_assignable_from()` checks are skipped only when dumping the "classic static archive".
>> 
>> In the AOT training run, CDS is configured to dump a "preimage static archive". I.e.,
>> 
>> - `CDSConfig::is_dumping_classic_static_archive()` == false
>> - `CDSConfig::is_dumping_preimage_static_archive()` == true
>> 
>> Therefore, the skipping no longer happens.
>> 
>> I added a test case and improve the comments in the C++ code.
>> 
>> (This bug is caused by [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), which is new in JDK 25. So it does not affect JDK 24 or earlier releases).
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @coleenp comments

After reading the other comments I understand your reasoning. Looks good!

-------------

Marked as reviewed by matsaave (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25104#pullrequestreview-2823292674