Integrated: 8356407: Part of class verification is skipped in AOT training run
Ioi Lam
iklam at openjdk.org
Thu May 8 01:11:07 UTC 2025
On Wed, 7 May 2025 17:29:25 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> Please see [JDK-8356407](https://bugs.openjdk.org/browse/JDK-8356407) for a detailed description of the problem.
>
> This fix strictly tightens the handling of class verification during CDS dump -- now the `VerificationType::is_reference_assignable_from()` checks are skipped only when dumping the "classic static archive".
>
> In the AOT training run, CDS is configured to dump a "preimage static archive". I.e.,
>
> - `CDSConfig::is_dumping_classic_static_archive()` == false
> - `CDSConfig::is_dumping_preimage_static_archive()` == true
>
> Therefore, the skipping no longer happens.
>
> I added a test case and improve the comments in the C++ code.
>
> (This bug is caused by [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), which is new in JDK 25. So it does not affect JDK 24 or earlier releases).
This pull request has now been integrated.
Changeset: 3e258cbd
Author: Ioi Lam <iklam at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3e258cbddf335a6b4f4307e5a1304fe2664c80a0
Stats: 120 lines in 5 files changed: 93 ins; 7 del; 20 mod
8356407: Part of class verification is skipped in AOT training run
Co-authored-by: Vladimir Ivanov <vlivanov at openjdk.org>
Reviewed-by: matsaave, coleenp
-------------
PR: https://git.openjdk.org/jdk/pull/25104
More information about the hotspot-runtime-dev
mailing list