RFR: 8356212: runtime/cds/appcds/LotsOfSyntheticClasses.java timed out with -XX:+AOTClassLinking [v2]

[Ioi Lam]

On Thu, 8 May 2025 19:54:33 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> The LotsOfSyntheticClasses.java test times out intermittently when the `open/test/hotspot/jtreg:hotspot_aot_classlinking` test group is run with the` -XX:+AOTClassLinking` option on macosx-aarch64 platform.
>> Increasing the timeout value from 500 to 800 seems to have addressed the issue.
>> With the change, there's no timeout when the test group is run 40 times on macosx-aarch64 with the same option.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @shipilev comment

Looks good to me.

FYI, I tried the following patch to avoid initializing the inner classes, but it doesn't seem to be any faster. So the current patch is good enough.


     public static List<String> generateClass(int idx) {
         List<String> out = new ArrayList<>();
         out.add("public class " + TOP_CLASS_NAME + idx + " {");
+        out.add("Object f;");
         out.add("public " + TOP_CLASS_NAME + idx + "() {");
         for (int c = 0; c < NUM_NESTED_CLASSES; c++) {
-            out.add("new " + NESTED_CLASS_NAME + c + "();");
+            out.add("f = " + NESTED_CLASS_NAME + c + ".class;");
         }

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25111#pullrequestreview-2826841535