RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v14]
Ioi Lam
iklam at openjdk.org
Mon May 12 17:20:56 UTC 2025
On Tue, 6 May 2025 21:50:34 GMT, Igor Veresov <iveresov at openjdk.org> wrote:
>> Improve warm-up time by making profile data from a previous run of an application instantly available, when the HotSpot Java Virtual Machine starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) to store method execution profiles from training runs, reducing profiling delays in subsequent production runs.
>>
>> More details in the JEP: https://bugs.openjdk.org/browse/JDK-8325147
>
> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review comments
LGTM. Small nits about logging and testing.
src/hotspot/share/cds/filemap.cpp line 1955:
> 1953: " does not equal the current SpecTrapLimitExtraEntries setting (%d).", file_type,
> 1954: _spec_trap_limit_extra_entries, SpecTrapLimitExtraEntries);
> 1955: return false;
The `log_info(cds)` should be replaced with `MetaspaceShared::report_loading_error`. (The few `log_info` lines above this block will be fixed in [JDK-8356807](https://bugs.openjdk.org/browse/JDK-8356807))
Also, could you add a new jtreg test case for this? You can see examples in `negativeTests` in the existing AOTFlags.java test case. I think you can add your checks into the new AOTProfileFlags.java test.
-------------
Marked as reviewed by iklam (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24886#pullrequestreview-2833939411
PR Review Comment: https://git.openjdk.org/jdk/pull/24886#discussion_r2085115469
More information about the hotspot-runtime-dev
mailing list