RFR: 8354887: Preserve runtime blobs in AOT code cache [v4]
Vladimir Kozlov
kvn at openjdk.org
Mon May 12 23:09:56 UTC 2025
On Mon, 12 May 2025 20:10:13 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> [8350209](https://bugs.openjdk.org/browse/JDK-8350209) introduced the framework for storing code in aot code cache and used it for caching i2c/c2i adapters.
>> This PR extends the `AOTCodeCache` infrastructure and stores various runtime blobs (shared blobs, C1 and C2 runtime blobs) in the AOT code cache. It adds a new diagnostic flag `AOTStubCaching` to enable/disable the caching of these blobs.
>> `AOTCodeFlags.java` test is extended to cover `AOTStubCaching`.
>
> Ashutosh Mehra has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove more unused code
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - Fix whitespace issue. Remove unused code.
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
src/hotspot/share/code/aotCodeCache.hpp line 374:
> 372:
> 373: static bool is_dumping_stubs() NOT_CDS_RETURN_(false);
> 374: static bool is_using_stubs() NOT_CDS_RETURN_(false);
We have singular naming (`is_dumping_stub()`) for these methods in `premain` branch.
I was debating to do separate RFE for renaming in mainline or may be you can do it here.
It is up to you.
I did not pay attention to these when I work on adapter caching. But now I have to merge from mainline to premain and I noticed difference.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25019#discussion_r2085650099
More information about the hotspot-runtime-dev
mailing list