RFR: 8354887: Preserve runtime blobs in AOT code cache [v2]
Ashutosh Mehra
asmehra at openjdk.org
Tue May 13 18:07:59 UTC 2025
On Mon, 12 May 2025 23:07:02 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>>> I think for these changes we should not use AOT code when the heap base does not match.
>> Something changed in compressed oops code which prevents enforcing encoding.
>> We can investigate and fix it later.
>>
>> @vnkozlov for this PR we are relying on having relocation for COOP base, not on enforcing encoding. And that should be able to handle cases where heap base is different in assembly vs prod. Why do you suggest to not use AOT code when the heap base does not match?
>
> @ashu-mehra, this looks good with few comments. After you address them, please merge latest jdk - I pushed small related change to limit platforms to run with AOT.
>
> After that I will submit new testing.
@vnkozlov addressed your comments.
I also noticed the newly added test `AOTCodeCompressedOopsTest` was consistently failing on macos-aarch64 because for some reason the CompressedOops::shift=3 even for heap size as low as for Xmx128m. So I have updated the test to make it more resilient by reading the 'actual' base and shift from Xlog:cds output.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25019#issuecomment-2877494411
More information about the hotspot-runtime-dev
mailing list