Integrated: 8356102: TestJcmdOutput, JcmdWithNMTDisabled and DumpSharedDictionary hs/tier1 tests fail on static-jdk
Jiangli Zhou
jiangli at openjdk.org
Wed May 14 15:01:14 UTC 2025
On Fri, 2 May 2025 23:16:50 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
> Please review the change to set `-Dcompile.jdk=<jdk>` when launching child processes in TestJcmdOutput, JcmdWithNMTDisabled and DumpSharedDictionary hs/tier1 tests.
>
> These three tests fail on static-jdk as `jdk.test.lib.JDKToolFinder.getJDKTool()` fails to locate the `jcmd` tool. `JDKToolFinder.getJDKTool()` locates the requested tool from the path specified in 'test.jdk' system property first, then using the path specified in 'compile.jdk' system property. Currently when running jtreg tests on static-jdk, jtreg '-compilejdk' is set to a regular JDK binary. Populating the 'compile.jdk' system property from jtreg when creating the child process would allow `JDKToolFinder.getJDKTool()` (executing in the child process) to locate the tool from 'compile.jdk' path.
>
> Tested all three tests on static-jdk. All three tests pass with the fix.
This pull request has now been integrated.
Changeset: 1afd887b
Author: Jiangli Zhou <jiangli at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/1afd887b138ac2425289b6f863801774f050c23c
Stats: 11 lines in 3 files changed: 6 ins; 2 del; 3 mod
8356102: TestJcmdOutput, JcmdWithNMTDisabled and DumpSharedDictionary hs/tier1 tests fail on static-jdk
Reviewed-by: dholmes
-------------
PR: https://git.openjdk.org/jdk/pull/25018
More information about the hotspot-runtime-dev
mailing list