RFR: 8350869: os::stat doesn't follow symlinks on Windows [v2]

[Anton Artemov]

On Thu, 15 May 2025 07:50:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8350869: Addressed reviewer's comments.
>
> src/hotspot/os/windows/os_windows.cpp line 4628:
> 
>> 4626: // This method dereferences a symbolic link
>> 4627: static WCHAR* get_path_to_target(const wchar_t* wide_path)
>> 4628: {
> 
> Suggestion:
> 
> static WCHAR* get_path_to_target(const wchar_t* wide_path) {

Addressed in the latest commit.

> src/hotspot/os/windows/os_windows.cpp line 4638:
> 
>> 4636: 
>> 4637:   if (target_path_size == 0)
>> 4638:   {
> 
> Suggestion:
> 
>   if (target_path_size == 0) {

Addressed in the latest commmit.

> test/hotspot/jtreg/runtime/LoadClass/TestSymlinkLoad.java line 89:
> 
>> 87:     public static void createLinkInSeparateFolder( final String pathToFolderForSymlink, final Path target, final String className) throws IOException {
>> 88:         File theDir = new File(pathToFolderForSymlink);
>> 89:         if (!theDir.exists()){
> 
> Suggestion:
> 
>         if (!theDir.exists()) {

Addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25233#discussion_r2091181371
PR Review Comment: https://git.openjdk.org/jdk/pull/25233#discussion_r2091180762
PR Review Comment: https://git.openjdk.org/jdk/pull/25233#discussion_r2091181892