RFR: 8350869: os::stat doesn't follow symlinks on Windows [v4]

Anton Artemov duke at openjdk.org
Fri May 16 11:07:54 UTC 2025


On Fri, 16 May 2025 06:16:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The only explicit way how to notify about the error I found is like this:
>> `log_info(os)("CreateFileMapping() failed: GetLastError->%ld.", GetLastError());`
>> Then one would not presumably need to set `errno`.
>> 
>> The question is rather if we want to see this message or just rely on the existing logic.
>
> A log_debug to report any error would not be a bad thing IMO.

I added log_debug statements in all the places where we call `GetLastError`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25233#discussion_r2092838996


More information about the hotspot-runtime-dev mailing list