RFR: 8357244: Move class declarations from attachListener_posix.cpp to header files

[David Holmes]

On Mon, 19 May 2025 11:09:43 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The patch suggests moving class declarations from `attachListener_posix.cpp` to header files
> 
> It's moved in `openjdk/crac` project ahead of upstream and this causes merge conflicts every time attachListener code changes (e.g. https://github.com/openjdk/crac/pull/224). It's therefore suggested that the changes are included in upstream.

I'm going to need to understand the motivation a bit better here. If these classes are not used by other code then they do not need to be in a header file. The fact they make merging easier in another project is not in itself sufficient motivation to me.

src/hotspot/os/posix/attachListener_posix.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.

src/hotspot/os/posix/posixAttachOperation.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25300#pullrequestreview-2852007496
PR Review Comment: https://git.openjdk.org/jdk/pull/25300#discussion_r2096494030
PR Review Comment: https://git.openjdk.org/jdk/pull/25300#discussion_r2096494554