RFR: 8350869: os::stat doesn't follow symlinks on Windows [v3]

David Holmes dholmes at openjdk.org
Tue May 20 02:15:53 UTC 2025


On Fri, 16 May 2025 10:18:13 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> src/hotspot/os/windows/os_windows.cpp line 4637:
>> 
>>> 4635:   WCHAR* path_to_target = NEW_C_HEAP_ARRAY(WCHAR, target_path_size + 1, mtInternal);
>>> 4636: 
>>> 4637:   ::GetFinalPathNameByHandleW(hFile, path_to_target, static_cast<DWORD>(target_path_size + 1),
>> 
>> Maybe save the return value and assert it is the expected one.
>
> We do not have an expected value here.

Well we could assert that the return value is >= 0  and not < target_path_size

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25233#discussion_r2096727107


More information about the hotspot-runtime-dev mailing list