RFR: 8356233: NMT: tty->print_cr should not be used in VirtualMemoryTracker::add_reserved_region() [v2]

[Gerard Ziemski]

On Tue, 20 May 2025 10:18:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 411:
>> 
>>> 409:                     "       new region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %s.",
>>> 410:                     p2i(reserved_rgn->base()), p2i(reserved_rgn->end()), NMTUtil::tag_to_name(mem_tag_old),
>>> 411:                     p2i(base_addr), p2i(base_addr + size), NMTUtil::tag_to_name(mem_tag_new));
>> 
>> This change also now prints the name instead of the index. If you do print the name, then you don't need to use `index_to_tag` as they already are `MemTag`s.
>
> +1 on Johan's comment

Good catch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25308#discussion_r2098339826