RFR: 8344270: Update tier1_common and hotspot_misc groups to better organize hotspot non-component tests [v3]

[David Holmes]

On Tue, 20 May 2025 14:44:48 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Can you please review following PR that improve test groups.
>> The bug was originally filed  to eliminate duplication between tier1_common and hotspot_misc test groups.  However while looked on the test content of these groups I realized that there are some other issues. 
>> 1) hotspot_resourcehogs groups should be executed always separately from other tests to don't cause intermittent failures.
>> 2) it makes sense to run all gtest tests in tier1 but don't run in any other tiers (with any VM flags) 
>> 3) testlibrary_tests and  sources should be a separate groups that don't need to be executed with any VM flags, or event with all builds 
>> 
>> So tier1_common includes non-component tests that should be executed in tier1. 
>> **all** sanity tests
>> **all** gttest tests (were not all of them)
>> testlibrary_tests (might be os/cpu specifc, so need to run them with all builds)
>> source code checking tests (no need to run them an all builds, but it takes only few seconds)
>> 
>> And it doesn't makes any sense to execute  tier1_common with any external VM flags.
>> 
>> While hotspot_misc now includes on 2 sanity tests.  It doesn't looks useful, but main purpose for this group would be to catch all tests that somehow missed from other groups. So let keep it. 
>> 
>> The new test groups were added mostly to add comments explaining their specific.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updated comment

I'm still somewhat unclear on the guidance being given here, but I tweaked some of the comments.

test/hotspot/jtreg/TEST.groups line 67:

> 65: # The resourcehogs tests might require a lot of resources  and
> 66: # shouldn't be executed concurrently with ANY other tests
> 67: # So the group shouldn't be part of any other group

Suggestion:

# The resourcehogs tests might require a lot of resources and
# shouldn't be executed concurrently with ANY other tests.
# So the group shouldn't be part of any other group.

test/hotspot/jtreg/TEST.groups line 72:

> 70: 
> 71: # The other tests includes all tests that don't
> 72: # test hotspot itself

Suggestion:

# The other tests includes all tests that don't
# test hotspot itself.

test/hotspot/jtreg/TEST.groups line 77:

> 75:   sources
> 76: 
> 77: # Gtest unit-test with jtreg wrapper, VM flags are set by test

Suggestion:

# Gtest unit-test with jtreg wrapper, VM flags are set by test,
# and so should not be executed with VM flags.

???

test/hotspot/jtreg/TEST.groups line 81:

> 79:  gtest
> 80: 
> 81: hotspot_misc = \

What is actually left in this group after all the listed excluded?

test/hotspot/jtreg/TEST.groups line 160:

> 158: # non_hotspot and gtest ignore them,
> 159: # hotspot_misc should be used for execution of
> 160: # all non-component tests with VM flags

Suggestion:

# tier1_common shouldn't be executed with VM flags, because
# non_hotspot and gtest ignore them.
# hotspot_misc should be used for execution of
# all non-component tests with VM flags.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25070#pullrequestreview-2855706612
PR Review Comment: https://git.openjdk.org/jdk/pull/25070#discussion_r2098952552
PR Review Comment: https://git.openjdk.org/jdk/pull/25070#discussion_r2098952750
PR Review Comment: https://git.openjdk.org/jdk/pull/25070#discussion_r2098953716
PR Review Comment: https://git.openjdk.org/jdk/pull/25070#discussion_r2098954609
PR Review Comment: https://git.openjdk.org/jdk/pull/25070#discussion_r2098955209