RFR: 8350869: os::stat doesn't follow symlinks on Windows [v5]

[Anton Artemov]

On Tue, 20 May 2025 22:17:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8350869: Clean up of the test, error handling in get_path_to_target
>
> src/hotspot/os/windows/os_windows.cpp line 4643:
> 
>> 4641:   // One does not need extra character in the end, from documentation:
>> 4642:   // "If the function fails because lpszFilePath is too small to hold the string plus the terminating null character,
>> 4643:   // the return value is the required buffer size, in TCHARs. This value INCLUDES the size of the terminating null character."
> 
> A simple:
> 
> // Returned value includes the terminating null character.
> 
> will suffice.

Thanks, addressed in the latest commit.

> src/hotspot/os/windows/os_windows.cpp line 4657:
> 
>> 4655:   // "If the function succeeds, the return value is the length of the string received by lpszFilePath,
>> 4656:   // in TCHARs.This value DOES NOT INCLUDE the size of the terminating null character."
>> 4657:   // So the return value is ONE LESS than target_path_size if everything is ok
> 
> Again please simplify:
> 
> // The returned size is the length excluding the terminating null character.

Thanks, addressed in the latest commit.

> src/hotspot/os/windows/os_windows.cpp line 4672:
> 
>> 4670:   }
>> 4671: 
>> 4672:   path_to_target[target_path_size - 1] = '\0';
> 
> Why are we explicitly adding the null character ourselves?

It was not clear from the documentation if the termination character is copied. It does get copied. Addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25233#discussion_r2100377116
PR Review Comment: https://git.openjdk.org/jdk/pull/25233#discussion_r2100377397
PR Review Comment: https://git.openjdk.org/jdk/pull/25233#discussion_r2100380494