RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v28]

Johan Sjölen jsjolen at openjdk.org
Thu May 22 08:04:55 UTC 2025


On Thu, 22 May 2025 07:38:13 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/nmt/vmatree.cpp line 47:
>> 
>>> 45: // (<from-address, to-address, operation, tag, call-stack, which-tag-to-use >) is sent to the tree to handle.
>>> 46: //
>>> 47: // The expected changes are described here for each operation:
>> 
>> I agree with the semantics of these operations.
>
> Hmm, what should I do here?

Nothing, I'm saying "good job, I agree with these definitions, good that we could get semantics that we agree on!" :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2101908180


More information about the hotspot-runtime-dev mailing list