RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v29]

[Johan Sjölen]

On Thu, 22 May 2025 08:55:30 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> test/hotspot/gtest/nmt/test_vmatree.cpp line 318:
>> 
>>> 316:   Tree tree;
>>> 317:   VMATree::RegionData rd1(si[0], mtTest);
>>> 318:   VMATree::RegionData rd2(si[1], mtNone);
>> 
>> We keep using those later in and it is hard to keep track of what `rd1` is. I suggest we use better names for those, such as `rd_Test`, then I know what mem_tag that region uses without having to go back.
>> 
>> I renamed other instances, like `call_stack_2` as well.
>> 
>> I have changed lots of those and here is a diff file with this change: [gerard.diff.zip](https://github.com/user-attachments/files/20376150/gerard.diff.zip)
>
> Unfortunately, your patch couldn't be applied, since it cannot find some expected text in my local code.

It's a lot easier to apply a patch by merging with git branches. Send the branch that's on your github instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2102028775