RFR: 8265754: Move suspend/resume API from HandshakeState [v2]

David Holmes dholmes at openjdk.org
Tue May 27 09:42:54 UTC 2025


On Mon, 26 May 2025 13:30:11 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Hi,
>> 
>> in this PR the suspend/resume methods are moved away from the HandshakeState class into a new separate class HandshakeSuspender. The idea is that the state class should be a state keeper and should not be responsible for actions which change the state. Such actions should be done by a separate class. 
>> 
>> Tested in tiers 1-4.
>
> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JDK-8265754
>  - Merge remote-tracking branch 'origin/master' into JDK-8265754
>  - 8265754: Refactoring to static methods.
>  - 8265754: Fixed indentation.
>  - 8265754: Fixed indentation
>  - 8265754: Fixed indentation and lost newline.
>  - 8265754: Fixed whitespaces errors.
>  - 8265754: More work.
>  - Merge remote-tracking branch 'origin/master' into JDK-8265754
>  - 8265754: Refactoring suspend/resume in the HandshakeState away

This refactoring seems okay to me.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25407#pullrequestreview-2870394317


More information about the hotspot-runtime-dev mailing list