RFR: 8357917: Assert in MetaspaceShared::preload_and_dump() when printing exception

Tue May 27 21:59:50 UTC 2025

On Tue, 27 May 2025 21:47:49 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this trivial patch for printing exceptions that happened during AOT cache dumping.
> 
> We observed the crash when running tests with [JEP 514](https://openjdk.org/jeps/514), but the root cause is pre-existing.

Good point fix.

20% of all API uses (82) of `java_lang_String::` are `as_utf8_String`.  We should consider moving the check for null, and substitution of `"(null)"`, into `as_utf8_String` on the grounds that (a) there is widespread use of this API point to build diagnostic strings, and (b) we'd like to close the door on this kind of NPE more consistently.

That is not needed for this point fix.  Should be a followup bug, so we can review the handling of null in diagnostics in a fuller manner.

-------------

Marked as reviewed by jrose (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25473#pullrequestreview-2872830484