RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v33]

Gerard Ziemski gziemski at openjdk.org
Fri May 30 17:10:58 UTC 2025


On Thu, 22 May 2025 13:37:39 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> In NMT detail mode, we need to have separate call-stacks for Reserve and Commit operations.
>> This PR adds a second stack to every node that will be used when committing (and uncommitting) the start node of a reserved region.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   visualizations added. 1st try.

Changes requested by gziemski (Reviewer).

test/hotspot/gtest/nmt/test_vmatree.cpp line 3211:

> 3209:     //            1         2         3         4         5
> 3210:     //  012345678901234567890123456789012345678901234567890
> 3211:     //  rrrrrrrrrr..........rrrrrrrrrr

What is this comment supposed to show?

I cleaned up, some comments and created a branch https://github.com/openjdk/jdk/compare/master...gerard-ziemski:jdk:gerard-8351661 in case you want to see it.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24028#pullrequestreview-2881928654
PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2116279532


More information about the hotspot-runtime-dev mailing list