RFR: 8366062: [ubsan] add non-zero offset to nullptr in cds/archiveBuilder.cpp [v6]

Afshin Zafari azafari at openjdk.org
Mon Nov 3 09:31:27 UTC 2025


On Mon, 20 Oct 2025 17:08:18 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix after wrong merge.
>
>> Dear @iklam , in #26955, it is suggested to use `uintptr_t` for addresses in pointer arithmetics and cast them to `address` when we pass them into functions. There are some of this conversions in related code here, do you want me to do this or as a separate RFE?
> 
> I think we should probably do that in a separate RFE. The CDS code has a mixed use of intptr_t, address and char* for addresses. We should probably change all of them to a single type, and I agree that  intptr_t is the best of the three.

Thank you @iklam and @dholmes-ora for your reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26983#issuecomment-3479613974


More information about the hotspot-runtime-dev mailing list