RFR: 8370975: OutputAnalyzer.matches() should use Matcher with Pattern.MULTILINE [v2]
Ioi Lam
iklam at openjdk.org
Tue Nov 4 11:56:53 UTC 2025
On Tue, 4 Nov 2025 10:05:42 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> > I didn't use "find", as all the existing methods in OutputAnalyzer use "match".
>
> My point is that you can't have a function called "matches" that performs a "find" instead of a "matches":
>
> ```
> private boolean matchesHelper(String s, Pattern pattern) {
> return s != null && pattern.matcher(s).find();
> }
> ```
>
> That's too confusing.
Thanks for the clarification. I've updated the code using your suggestion.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28077#issuecomment-3485603985
More information about the hotspot-runtime-dev
mailing list