RFR: 8370254: Add VM_MEMORY_JAVA mmap tag to MacOS mmap calls [v6]

[Axel Boldt-Christmas]

On Tue, 4 Nov 2025 19:07:32 GMT, Nityanand Rai <duke at openjdk.org> wrote:

>> Add VM_MEMORY_JAVA tag to mmap calls in os_bsd.cpp for better memory tracking of java process on macOs
>
> Nityanand Rai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor refactoring to reduce code duplication

src/hotspot/os/bsd/os_bsd.hpp line 38:

> 36: // Shared constant for mmap file descriptor used across BSD OS implementations
> 37: static constexpr int bsd_mmap_fd =
> 38: #ifdef __APPLE__

Are these defines always available (present and future)? Or should they be guarded?
Suggestion:

#if defined(__APPLE__) && defined(VM_MAKE_TAG) && defined(VM_MEMORY_JAVA)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27868#discussion_r2494939644