RFR: 8370492: [Linux] Update cpu shares to cpu.weight mapping function [v2]

SendaoYan syan at openjdk.org
Mon Nov 10 09:41:03 UTC 2025


On Mon, 10 Nov 2025 09:22:01 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> test/jdk/jdk/internal/platform/docker/MetricsCpuTester.java line 151:
>> 
>>> 149:             // have a 1-to-1 mapping from the cgroup v2 value to the OCI
>>> 150:             // value.
>>> 151:             System.out.println("Debug: cgv2 - Got CPU shares of: " +
>> 
>> I found you 'import jtreg.SkippedException;' on file test/hotspot/jtreg/containers/docker/TestMisc.java. Do you want to 'throw new SkippedException' rather that just print 'Skipping assert'
>
> I'd rather not, since by throwing `SkippedException` the other tests won't run either. It's useful to see various values for the back-mapped value. In this case it should be a value < 1024 which is asserted by the if. Later, we have actual assertions in the test for `1024` and `2048`. Does that make sense?

So does the 'import jtreg.SkippedException;' in file test/hotspot/jtreg/containers/docker/TestMisc.java seems do not needed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28157#discussion_r2509574859


More information about the hotspot-runtime-dev mailing list