RFR: 8372135: clang compilation error

[Johan Sjölen]

On Wed, 19 Nov 2025 07:59:32 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> clang-20.1.8-4.fc42.x86_64
> 
> src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:212:10: error: 'is_containerized' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>   212 |     bool is_containerized();
>       |          ^       
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp:284:18: note: overridden virtual function is here
>   284 |     virtual bool is_containerized() = 0;
>       |                  ^
> In file included from src/hotspot/os/linux/cgroupSubsystem_linux.cpp:27:
> src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:214:18: error: 'container_type' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>   214 |     const char * container_type() {
>       |                  ^
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp:288:26: note: overridden virtual function is here
>   288 |     virtual const char * container_type() = 0;
>       |                          ^
> In file included from src/hotspot/os/linux/cgroupSubsystem_linux.cpp:27:
> src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:217:54: error: 'memory_controller' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>   217 |     CachingCgroupController<CgroupMemoryController>* memory_controller() { return _memory; }
>       |                                                      ^
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp:289:62: note: overridden virtual function is here
>   289 |     virtual CachingCgroupController<CgroupMemoryController>* memory_controller() = 0;
>       |                                                              ^
> In file included from src/hotspot/os/linux/cgroupSubsystem_linux.cpp:27:
> src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:218:51: error: 'cpu_controller' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>   218 |     CachingCgroupController<CgroupCpuController>* cpu_controller() { return _cpu; }
>       |                                                   ^
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp:290:59: note: overridden virtual function is here
>   290 |     virtual CachingCgroupController<CgroupCpuController>* cpu_controller() = 0;
>       |                                                           ^
> In file included from src/hotspot/os/linux/cgroupSubsystem_linux.cpp:27:
> src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:219:30: error: 'cpuacct_controller' overrides a member function but is not marked...

Marked as reviewed by jsjolen (Reviewer).

Please wait 24 hours before integrating. This is so that all contributors get a chance to see your PR.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28384#pullrequestreview-3481599536
PR Comment: https://git.openjdk.org/jdk/pull/28384#issuecomment-3551605076